Benjamin Otte [Mon, 15 Feb 2016 23:22:40 +0000 (00:22 +0100)]
win32 theme: Include the default win32 colors
Benjamin Otte [Mon, 15 Feb 2016 23:22:12 +0000 (00:22 +0100)]
win32 theme: Always include the win32 theme
It's not very useful outside of Windows so far, but that will hopefully
change.
Lapo Calamandrei [Tue, 16 Feb 2016 01:11:12 +0000 (02:11 +0100)]
Adwaita: stop using assets for treeview check/radio...
...the sizing is still off, waiting for Benjamin to add the magic,
probably the icon shadow is missing, not sure since it's blurry.
This needs to be reverted in case the sizing won't get fixed.
Matthias Clasen [Mon, 15 Feb 2016 19:20:48 +0000 (14:20 -0500)]
Some more CSS node tests for notebooks
Carlos Garnacho [Mon, 15 Feb 2016 17:56:42 +0000 (18:56 +0100)]
gdkdnd: Stick to the first gdk_drag_drop_done() result
That way we can let ::cancel callers to override the visual
result of the operation (eg. when detaching notebook tabs on
NO_TARGET).
Also, document gdk_drag_drop_done() so it is mentioned that
this is a one-shot call.
https://bugzilla.gnome.org/show_bug.cgi?id=761954
Lapo Calamandrei [Mon, 15 Feb 2016 17:39:50 +0000 (18:39 +0100)]
Adwaita: correctly style arrows wrt tab position
Anders Jonsson [Mon, 15 Feb 2016 17:39:17 +0000 (17:39 +0000)]
Updated Swedish translation
Anders Jonsson [Mon, 15 Feb 2016 17:38:07 +0000 (17:38 +0000)]
Updated Swedish translation
Carlos Garnacho [Mon, 15 Feb 2016 16:05:50 +0000 (17:05 +0100)]
gdkdnd: Make GtkDragContext::cancel RUN_LAST
The default implementation code should act as a catch-all fallback,
we let the connected handlers to run first then.
https://bugzilla.gnome.org/show_bug.cgi?id=761954
Carlos Garnacho [Mon, 15 Feb 2016 16:02:14 +0000 (17:02 +0100)]
gdk: Add GdkDragCancelReason enum as argument to GdkDragContext::cancel
We should conform to a minimal set of reasons for the gtk side to emit
a better GtkDragResult than GTK_DRAG_RESULT_ERROR. This fixes the notebook
tab DnD feature, where we rely on GTK_DRAG_RESULT_NO_TARGET.
In the wayland side, unfortunately we can't honor either NO_TARGET nor
USER_CANCELLED, we don't know of the latter, so we could return false
positives on the former.
https://bugzilla.gnome.org/show_bug.cgi?id=761954
Benjamin Otte [Mon, 15 Feb 2016 17:16:32 +0000 (18:16 +0100)]
cellrendertoggle: Draw background + frame for mark
Also compute padding and borders properly for the marks.
Benjamin Otte [Mon, 15 Feb 2016 17:08:14 +0000 (18:08 +0100)]
cellrenderertoggle: Split out a function
Benjamin Otte [Mon, 15 Feb 2016 17:06:28 +0000 (18:06 +0100)]
widget-factory: Add myself
Actually, I wanted to have a radio toggle cell renderer for testing. But
hey, the commit message is supposed to say the important things!
Lapo Calamandrei [Mon, 15 Feb 2016 15:56:01 +0000 (16:56 +0100)]
Adwaita: correct size for ssd titlebars
fixes https://bugzilla.gnome.org/show_bug.cgi?id=762032
Matthias Clasen [Mon, 15 Feb 2016 15:38:13 +0000 (10:38 -0500)]
notebook: Fix a misplaced tab label
Sometimes default tab labels ("Page <n>") get created on-demand,
and in that case, we were forgetting to put them below the tab
node in the CSS node tree. The visible result of this is that the
heuristics for when to give notebooks background in Adwaita fail
in some cases. So, make sure to always place the label below the
tab node.
Caolán McNamara [Mon, 15 Feb 2016 13:06:23 +0000 (13:06 +0000)]
gtk-demo: add menu separator demo
doesn't much look like the menu separator in a real menu though.
https://bugzilla.gnome.org/show_bug.cgi?id=762080
Caolán McNamara [Mon, 15 Feb 2016 12:38:52 +0000 (12:38 +0000)]
gtk-demo: add combobox demos
https://bugzilla.gnome.org/show_bug.cgi?id=762080
Caolán McNamara [Thu, 11 Feb 2016 16:48:51 +0000 (16:48 +0000)]
gtk-demo: add menu check and radio examples
note that if the "menu" context has no parent then the GTK_STATE_FLAG_NORMAL
menu entries are invisible against the white background.
https://bugzilla.gnome.org/show_bug.cgi?id=762080
Lapo Calamandrei [Mon, 15 Feb 2016 13:25:30 +0000 (14:25 +0100)]
Adwaita: notebook fixes
make the tab close button a tad bigger, use header 'paddings' in
place of 'tabs' margins for spacing.
Matthias Clasen [Mon, 15 Feb 2016 13:23:12 +0000 (08:23 -0500)]
Expand the docs for gtk_window_set_default_size()
Mention that this function should be used together with
gtk_window_get_size() when saving and restoring window sizes.
Matthias Clasen [Mon, 15 Feb 2016 13:02:27 +0000 (08:02 -0500)]
places sidebar: use a box
No need for a grid here. Patch by Timm Bäder.
Lapo Calamandrei [Mon, 15 Feb 2016 12:52:41 +0000 (13:52 +0100)]
Adwaita: sidebar background-color
it was covered by the contained list background, which is now
transparent.
Lapo Calamandrei [Mon, 15 Feb 2016 12:30:37 +0000 (13:30 +0100)]
Adwaita: no rounded corner for tiled backdrop windows
fixes https://bugzilla.gnome.org/show_bug.cgi?id=762067
Lapo Calamandrei [Mon, 15 Feb 2016 12:28:46 +0000 (13:28 +0100)]
Revert "Adwaita: no rounded corners for backdrop tiled windows"
This reverts commit
aa4b385398e99fed6dd71791eb5a9e2e5ea4db9d.
Erroneusly pushed unfinished stuff...
Lapo Calamandrei [Mon, 15 Feb 2016 12:07:37 +0000 (13:07 +0100)]
Adwaita: shortcutswindow fixes
use darker text and tweak the keycap vertical centering,
addresses https://bugzilla.gnome.org/show_bug.cgi?id=761778
Lapo Calamandrei [Mon, 15 Feb 2016 11:34:55 +0000 (12:34 +0100)]
Adwaita: no rounded corners for backdrop tiled windows
fixes https://bugzilla.gnome.org/show_bug.cgi?id=762067
Chun-wei Fan [Mon, 15 Feb 2016 09:22:00 +0000 (17:22 +0800)]
gtk/gtkentry.c: Fix build on pre-C99
This file now uses nearbyint(), so include fallback-c89.c so that
compilers that don't provide the function will not get upset.
Chun-wei Fan [Mon, 15 Feb 2016 06:34:12 +0000 (14:34 +0800)]
Fix 'make dist'
Benjamin Otte [Mon, 15 Feb 2016 03:40:03 +0000 (04:40 +0100)]
cellrenderertoggle: Use "check" and "radio" names
... instead of just adding a style class.
Benjamin Otte [Mon, 15 Feb 2016 03:28:13 +0000 (04:28 +0100)]
win32 theme: Remove a bunch of workarounds that are no longer necessary
Benjamin Otte [Mon, 15 Feb 2016 00:47:43 +0000 (01:47 +0100)]
win32 theme: Draw checkmarks and radiomarks properly
Instead of drawing them as the background, use -gtk-icon-source.
Also size the marks properly.
Because Windows doesn't have indeterminate radio buttons, use a
cross-fade between checked and unchecked radiomark instead. But
unlike previously, use CSS cross-fade() syntax to draw it.
Benjamin Otte [Mon, 15 Feb 2016 00:46:29 +0000 (01:46 +0100)]
cssimagecrossfade: Fix order of images when parsing/printing
The syntax is cross-fade(<percentage> <end>, <start>), not the
other way around. That's because the percentage refers to the end image.
Benjamin Otte [Sun, 14 Feb 2016 23:49:29 +0000 (00:49 +0100)]
win32: Add support for -gtk-win32-part-width/height to CSS
It's unused by now, but I want it for min-width of checks/radios.
Benjamin Otte [Sun, 14 Feb 2016 19:36:38 +0000 (20:36 +0100)]
win32 theme: Don't set the color on *
Instead, set it on .background, so it gets inherited everywhere.
Benjamin Otte [Sun, 14 Feb 2016 17:01:07 +0000 (18:01 +0100)]
win32 theme: Use same spinner as Adwaita
Benjamin Otte [Sun, 14 Feb 2016 15:18:56 +0000 (16:18 +0100)]
win32: Update color handling to recent GtkWin32Theme changes
Benjamin Otte [Sun, 14 Feb 2016 03:51:37 +0000 (04:51 +0100)]
win32: Canonicalize theme-name before adding to hash table
This way, we get rid of du0plicates.
Benjamin Otte [Sun, 14 Feb 2016 00:11:57 +0000 (01:11 +0100)]
win32: Add gtk_win32_theme_parse()
So all places can use this function instead of parsing things themselves.
Benjamin Otte [Sat, 13 Feb 2016 23:54:37 +0000 (00:54 +0100)]
css: Add a number value handling win32 sizes
Lapo Calamandrei [Sun, 14 Feb 2016 21:30:32 +0000 (22:30 +0100)]
Adwaita: fix treeview dnd column headers
Lapo Calamandrei [Sun, 14 Feb 2016 20:48:31 +0000 (21:48 +0100)]
Adwaita: flatten up search bars and inline toolbars
Lapo Calamandrei [Sun, 14 Feb 2016 20:06:38 +0000 (21:06 +0100)]
Adwaita: image-button sizing fix
Matthias Clasen [Sun, 14 Feb 2016 19:54:49 +0000 (14:54 -0500)]
Adwaita: Fix a padding problem in action bars
Padding adds up. A selector like "actionbar box" matches any box
inside an actionbar, so nested boxes accumulate more and more
padding. The intention clearly was to just give padding to the
topmost box that is the direct child of the actionbar's revealer.
https://bugzilla.gnome.org/show_bug.cgi?id=762036
Matthias Clasen [Sun, 14 Feb 2016 15:49:22 +0000 (10:49 -0500)]
gtk3-demo: Fontify all source files
Matthias Clasen [Sun, 14 Feb 2016 14:39:15 +0000 (09:39 -0500)]
gtk-demo: Streamline application
Avoid the odd #ifdef STANDALONE construction; we can show
multiple source files nowadays.
Matthias Clasen [Sun, 14 Feb 2016 14:29:55 +0000 (09:29 -0500)]
gtk-demo: Fix the size saving for CSD
We need to use gtk_window_get_size to get the correct size that
we can pass to gtk_window_set_default_size regardless of CSD
or not.
Lapo Calamandrei [Sun, 14 Feb 2016 15:38:42 +0000 (16:38 +0100)]
Adwaita: correct spacing for mixed buttons
Benjamin Otte [Sun, 14 Feb 2016 15:10:07 +0000 (16:10 +0100)]
paned: Fix drawing
Clip children to their window's size. That way no overdraw happens for
these widgets. But don't clip the handle.
We might in the future consider not clipping un-shrinkable children.
https://bugzilla.gnome.org/show_bug.cgi?id=762021
Benjamin Otte [Sun, 14 Feb 2016 15:07:06 +0000 (16:07 +0100)]
paned: Use content allocation instead of widget allocation
We don't want to include padding and borders in our calculations
involving the handle.
Benjamin Otte [Sun, 14 Feb 2016 14:52:19 +0000 (15:52 +0100)]
paned: rtl-flip with the correct rectangle
Lapo Calamandrei [Sun, 14 Feb 2016 13:44:57 +0000 (14:44 +0100)]
Adwaita: don't set a border for drop targets
to avoid active drop targets to grow.
Lapo Calamandrei [Sun, 14 Feb 2016 13:33:30 +0000 (14:33 +0100)]
Adwaita: scss cosmetic changes
Lapo Calamandrei [Sun, 14 Feb 2016 13:21:01 +0000 (14:21 +0100)]
Adwaita: fix scale popup button size
Michael Catanzaro [Sun, 14 Feb 2016 04:14:55 +0000 (22:14 -0600)]
Fix a typo
Matthias Clasen [Sun, 14 Feb 2016 03:53:16 +0000 (22:53 -0500)]
gtk-demo: Add window size saving example
Implement the recommendations from
https://wiki.gnome.org/HowDoI/SaveWindowState
in the Application Class example.
Matthias Clasen [Sun, 14 Feb 2016 02:46:40 +0000 (21:46 -0500)]
gtk-demo: modernize the application demo
Subclass GtkApplication and GtkApplicationWindow
and use a template.
Lapo Calamandrei [Sun, 14 Feb 2016 01:35:28 +0000 (02:35 +0100)]
Adwaita: try being smarter wrt extending buttons.
Lapo Calamandrei [Sun, 14 Feb 2016 00:20:02 +0000 (01:20 +0100)]
Revert "Adwaita: remove an unneded selector."
This reverts commit
05dff4ccb014e32b572505fb098006aa80a72387.
It was needed actually...
Lapo Calamandrei [Sat, 13 Feb 2016 23:34:29 +0000 (00:34 +0100)]
Adwaita: remove an unneded selector.
Lapo Calamandrei [Sat, 13 Feb 2016 23:25:04 +0000 (00:25 +0100)]
Adwaita: notebook arrow styling.
Matthias Clasen [Sat, 13 Feb 2016 22:11:59 +0000 (17:11 -0500)]
widget-factory: Add an inline toolbar example
This pattern is still used in applications, so we should have it
represented here to keep it working well.
Matthias Clasen [Sat, 13 Feb 2016 04:40:26 +0000 (23:40 -0500)]
Docuemnt calc() support in CSS
Chao-Hsiung Liao [Sat, 13 Feb 2016 06:19:31 +0000 (06:19 +0000)]
Updated Chinese (Taiwan) translation
Chao-Hsiung Liao [Sat, 13 Feb 2016 06:17:15 +0000 (06:17 +0000)]
Updated Chinese (Taiwan) translation
Benjamin Otte [Sat, 13 Feb 2016 05:41:29 +0000 (06:41 +0100)]
testsuite: Don't use deprecated APIs
Benjamin Otte [Sat, 13 Feb 2016 05:26:42 +0000 (06:26 +0100)]
tests: Port testlockbutton to GTask
Get rid of deprecations that way.
Benjamin Otte [Sat, 13 Feb 2016 03:47:51 +0000 (04:47 +0100)]
css: Implement transitions for numbers of different units
We now can transition from 10px to 100%.
Note that this requires a teensy tiny hack in
gtk_css_value_transition(), but so be it.
Benjamin Otte [Sat, 13 Feb 2016 03:12:45 +0000 (04:12 +0100)]
calc: Allow subterms with '(' ')' bracketing
Some more tests included.
Benjamin Otte [Sat, 13 Feb 2016 02:56:12 +0000 (03:56 +0100)]
css: Add support for '*' and '/' to calc()
More tests are included.
Benjamin Otte [Sat, 13 Feb 2016 01:31:47 +0000 (02:31 +0100)]
css: Add API to handle order when printing calc()
Also, add some tests and update old ones to print calc() statements
correctly.
Benjamin Otte [Fri, 12 Feb 2016 06:59:06 +0000 (07:59 +0100)]
css: Add support for sums to calc()
This requires adding code to do math on number values:
gtk_css_number_value_multiply()
and
gtk_css_number_value_try_add()
were added to achieve that.
Some tests are included.
Benjamin Otte [Fri, 12 Feb 2016 05:56:14 +0000 (06:56 +0100)]
css: Add initial support for calc()
So far, calc() only supports literals, ie it's completely useless.
Benjamin Otte [Fri, 12 Feb 2016 05:45:06 +0000 (06:45 +0100)]
css: Add gtk_css_number_value_can_parse()
Use it instead of _gtk_css_parser_has_number().
We need that once we introduce calc() support.
Benjamin Otte [Fri, 12 Feb 2016 05:25:50 +0000 (06:25 +0100)]
css: Turn number values into a virtual type
GtkCssNumberValue is now a base class for numbers.
Actual numbers are now implemented in GtkCssDimensionValue. The name is
borrowed from the CSS spec, so there.
Benjamin Otte [Fri, 12 Feb 2016 03:40:35 +0000 (04:40 +0100)]
cssnumbervalue: Remove gtk_css_number_value_get_unit()
This is in preparation for calc(), as calc(50% - 5px) is valid CSS
but has 2 units. Instead, add a function to query a value's dimension
(so we can differentiate lengths from numbers) and add a function to
query if the value contains percentages.
Benjamin Otte [Fri, 12 Feb 2016 03:09:44 +0000 (04:09 +0100)]
linear-gradient: Remove the hack using NUMBER
Instead, add a "side" member to the struct that keeps sides explicitly.
Benjamin Otte [Fri, 12 Feb 2016 20:22:23 +0000 (21:22 +0100)]
cssimageradial: Don't print 2 spaces
Matthias Clasen [Sat, 13 Feb 2016 03:26:04 +0000 (22:26 -0500)]
gadget: Be careful in geometry calculations
Margins can be negative, and if we are not careful, then
content+padding+margin can end up with negative dimensions,
which can upset pixman and others. This commit ensures
that a gadget will not request or draw boxes with negative
dimensions, and get_border_allocation and get_content_allocation
will not return boxes with negative dimensions.
This fixes a crash in the paned separator drawing code that
can be reproduced by setting separator padding to 0.
https://bugzilla.gnome.org/show_bug.cgi?id=759657
Matthias Clasen [Sat, 13 Feb 2016 03:05:40 +0000 (22:05 -0500)]
file chooser: Avoid nonworking search+save combinations
With the location entry up in the header bar in save mode, we can
end up with the search model being in use when the user types in
the location entry. In this case, we don't make the Save button
sensitive as we should.
Having two entries in the dialog is somewhat confusing anyway,
so just stop the search when the user starts typing in the location
entry.
https://bugzilla.gnome.org/show_bug.cgi?id=761757
Matthias Clasen [Sat, 13 Feb 2016 01:35:26 +0000 (20:35 -0500)]
file chooser: Use the right model when getting the selection
We don't need to make assumptions about which model is currently
used since gtk_tree_selection_get_selection hands us the model.
https://bugzilla.gnome.org/show_bug.cgi?id=761757
Matthias Clasen [Fri, 12 Feb 2016 23:24:20 +0000 (18:24 -0500)]
Adwaita: Insensitive notebook arrows
Just make insensitive notebook arrows gray until better
styling appears.
https://bugzilla.gnome.org/show_bug.cgi?id=761716
Matthias Clasen [Fri, 12 Feb 2016 23:09:41 +0000 (18:09 -0500)]
paned: Draw handle before children
Carlos Garnacho [Fri, 12 Feb 2016 20:59:29 +0000 (21:59 +0100)]
x11: Avoid setting has_pointer_focus if a EWMH compliant WM is present
This is mostly useful to have focus behave sanely on lack of WM, so avoid
any check there if we're positive there is a WM handling focus.
https://bugzilla.gnome.org/show_bug.cgi?id=677329
Matthias Clasen [Fri, 12 Feb 2016 20:01:58 +0000 (15:01 -0500)]
paned: Don't overdraw
When moving children 'off', we can't allow them to draw outside
the paned allocation, so clip when drawing.
https://bugzilla.gnome.org/show_bug.cgi?id=761903
Caolán McNamara [Thu, 11 Feb 2016 17:22:31 +0000 (17:22 +0000)]
gtk-demo: spinbutton and menubar examples
https://bugzilla.gnome.org/show_bug.cgi?id=761900
Jakub Steiner [Fri, 12 Feb 2016 13:38:03 +0000 (14:38 +0100)]
Adwaita: make popovers less 1995
- use regular bgcolor
Carlos Garcia Campos [Fri, 12 Feb 2016 12:21:14 +0000 (13:21 +0100)]
Revert "Remove _gtk_box_get_children"
This reverts commit
572e9a04027e213082a5b257e5d662a5daa32667.
_gtk_box_get_children was not doing exactly the same than
gtk_container_get_children does, because the latter uses the forall
implementation of GtkBox that takes into account the children pack mode while
the former just iterated the list of children. This broke the order of
the buttons in a GtkButtonBox when they were packaged with PACK_END.
Matthias Clasen [Fri, 12 Feb 2016 03:51:35 +0000 (22:51 -0500)]
placessidebar: Increase padding
This should bring us back to the look of 3.18.
https://bugzilla.gnome.org/show_bug.cgi?id=761791
Colomban Wendling [Wed, 10 Feb 2016 18:43:34 +0000 (19:43 +0100)]
treeview: Make sure the editing widget's top left is always visible
https://bugzilla.gnome.org/show_bug.cgi?id=761838
Matthias Clasen [Fri, 12 Feb 2016 03:35:11 +0000 (22:35 -0500)]
Adwaita: Don't grow flat entries
Entries in treeviews and similar embedded situations don't really
work well if their height is forced to be big. Take out the min-height
for these.
https://bugzilla.gnome.org/show_bug.cgi?id=761686
Caolán McNamara [Tue, 26 Jan 2016 12:08:01 +0000 (12:08 +0000)]
cannot not -> must
https://bugzilla.gnome.org/show_bug.cgi?id=761826
Matthias Clasen [Fri, 12 Feb 2016 03:15:43 +0000 (22:15 -0500)]
placesview: Fix some minor issues
Make the button not grow too big, and ensure that the actionbar
has a background.
https://bugzilla.gnome.org/show_bug.cgi?id=761792
Matthias Clasen [Fri, 12 Feb 2016 03:03:47 +0000 (22:03 -0500)]
Adwaita: tone down treeview separators
John Ralls [Thu, 11 Feb 2016 21:49:07 +0000 (13:49 -0800)]
Fix Quartz clipboard image retrieval.
It does no good to iterate through a series of mime types to call a
function when the eventually-called function,
_gtk_quartz_get_selection_data_from_pasteboard() in this case, gives the
wrong answer and stops the iteration on all but one especially if that
one isn't first.
The one is "image/tiff" and the quartz pasteboard function will return
any image type Quartz knows about for it, so lose the iteration and use
only "image/tiff".
Lapo Calamandrei [Thu, 11 Feb 2016 17:38:31 +0000 (18:38 +0100)]
Adwaita: fix bogus selector...
...ruining the indeterminate check animation
Lapo Calamandrei [Thu, 11 Feb 2016 17:27:25 +0000 (18:27 +0100)]
Adwaita: animate check and radios
Emmanuele Bassi [Thu, 11 Feb 2016 11:59:12 +0000 (11:59 +0000)]
mir: Add C++ guards
Avoid missing symbols when compiling C++ including the GDK Mir backend
header.
https://bugzilla.gnome.org/show_bug.cgi?id=761829
Matthias Clasen [Thu, 11 Feb 2016 11:47:28 +0000 (06:47 -0500)]
notebook: fix arrow states
Some code was confusing 0 with ARROW_NONE, causing us to not properly
update the state of the arrow gadgets.
Benjamin Otte [Thu, 11 Feb 2016 03:14:56 +0000 (04:14 +0100)]
inspector: Don't use unused variables
Windows-specific refactorings broke this.
Benjamin Otte [Thu, 11 Feb 2016 03:14:28 +0000 (04:14 +0100)]
win32: Move init code into windows-specific code
Avoids warnings about undefined functions on non-windows.